Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/8276#discussion_r37501357
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala
---
@@ -98,27 +98,17 @@ private[r] object SQLUtils {
val bos = new ByteArrayOutputStream()
val dos = new DataOutputStream(bos)
- SerDe.writeInt(dos, row.length)
- (0 until row.length).map { idx =>
- val obj: Object = row(idx).asInstanceOf[Object]
- SerDe.writeObject(dos, obj)
- }
+ val cols = (0 until row.length).map { idx =>
row(idx).asInstanceOf[Object]}.toArray
--- End diff --
we should have one extra space after `[Object]` before `}`. In fact if the
whole map fits on one line you can just use `map(idx => ...).toArray`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
