Github user alope107 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8318#discussion_r37559580
  
    --- Diff: python/pyspark/__init__.py ---
    @@ -36,6 +36,31 @@
           Finer-grained cache persistence levels.
     
     """
    +import os
    +import sys
    +
    +import xml.etree.ElementTree as ET
    +
    +if (os.environ.get("SPARK_HOME", "not found") == "not found"):
    --- End diff --
    
    Currently, the only autodetection logic that findspark has is to check 
where homebrew installs Spark on OSX. I think that for pyspark this is overly 
specific and brittle, and can lead to confusion if the user wanted to use 
pyspark with a different version than the one installed by homebrew. Having the 
user set SPARK_HOME themself makes the process unambiguous. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to