Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8385#discussion_r37719391
  
    --- Diff: docs/running-on-yarn.md ---
    @@ -21,32 +21,51 @@ There are two deploy modes that can be used to launch 
Spark applications on YARN
     Unlike in Spark standalone and Mesos mode, in which the master's address 
is specified in the `--master` parameter, in YARN mode the ResourceManager's 
address is picked up from the Hadoop configuration. Thus, the `--master` 
parameter is `yarn-client` or `yarn-cluster`. 
     To launch a Spark application in `yarn-cluster` mode:
     
    -   `$ ./bin/spark-submit --class path.to.your.Class --master yarn-cluster 
[options] <app jar> [app options]`
    -    
    +   `$ ./bin/spark-submit --class path.to.your.Class --master yarn 
--deploy-mode yarn-client/yarn-cluster [options] <app jar> [app options]`
    +   
     For example:
     
         $ ./bin/spark-submit --class org.apache.spark.examples.SparkPi \
    -        --master yarn-cluster \
    +        --master yarn \
    +        --deploy-mode cluster
             --num-executors 3 \
             --driver-memory 4g \
             --executor-memory 2g \
             --executor-cores 1 \
             --queue thequeue \
             lib/spark-examples*.jar \
    -        10
    +        
    +`--deploy-mode` can be either client or cluster.
    --- End diff --
    
    As per above, explain this before the examples not after (and, nit, you can 
backtick-quote keywords)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to