Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8383#discussion_r37722489
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -142,6 +142,12 @@ private[sql] abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
joins.SortMergeOuterJoin(
leftKeys, rightKeys, RightOuter, condition, planLater(left),
planLater(right)) :: Nil
+ case ExtractEquiJoinKeys(FullOuter, leftKeys, rightKeys, condition,
left, right)
--- End diff --
I think you can coalesce this and the 2 cases above into
case ExtractEquiJoinKeys(joinType, leftKeys, rightKeys, condition, left,
right) if ...
RowOrdering.isOrderable(leftKeys) is enough, we don't need to check right
since the leftKeys and rightKeys should have the same orderable property.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
