Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8308#discussion_r37745530
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -769,7 +790,9 @@ class DAGScheduler(
}
}
- /** Called when stage's parents are available and we can now do its
task. */
+ /**
+ * Called when stage's parents are available and we can now do its task.
--- End diff --
The changes here that just make scaladoc into a multiline comment don't do
anything .. it's still valid on one line. I think the other changes look fine,
and this is a no-op at best, but personally would not change these lines if
there is no functional change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
