Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/8395#issuecomment-134241071
  
    I get it, it's maybe because the one path is not cached. This looks good to 
me. The only thing I wonder is this: clearly the code is expecting that the 
input should be cached, and it might not be cached in memory. This creates an 
additional cache, always in memory. However, since several code paths already 
behave this way it seems more consistent to be consistent, and then the 
warnings don't make as much sense.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to