Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8013#discussion_r37787158
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -65,6 +65,10 @@ private[shared] object SharedParamsCodeGen {
isValid = "ParamValidators.inArray(Array(\"skip\", \"error\"))"),
ParamDesc[Boolean]("standardization", "whether to standardize the
training features" +
" before fitting the model.", Some("true")),
+ ParamDesc[Boolean]("robustRegression", "whether to use robust Huber
Cost Function",
--- End diff --
I think it would be better to introduce a "costFunction" param which
defaults to "LeastSquares" and pattern match in LinearRegression#L195 since
that will force mutual exclusivity when more than two cost functions are
possible
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
