Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/7052#discussion_r37814522 --- Diff: launcher/src/main/java/org/apache/spark/launcher/package-info.java --- @@ -45,5 +45,33 @@ * } * } * </pre> + * + * <p> + * Since Spark 1.5.0, the {@link org.apache.spark.launcher.SparkLauncher#startApplication( --- End diff -- I think this should go above the section on `launch`, the `launch` section should clearly state its the old way of doing things.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org