Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8409#issuecomment-134483133 If you change `MAX_SCALE`, we are changing the maximum scale we can support, right? I feel the right solution is fixing https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala#L143 (if the calculated precision is greater than 38, we set it to 38 and then we adjust scale accordingly to prevent integral part of the number from being truncated). @davies what do you think?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org