Github user sabhyankar commented on the pull request:
https://github.com/apache/spark/pull/8241#issuecomment-134796319
@feynmanliang @jkbradley thank you for the review guys. Traits will not
allow context bound (to ClassTag) for type parameters and so I ended up using
implicits in the method. I am going to try doing an upper bound with a self
type annotation. However, I feel we are still going to need an implicit in the
method (ill see if the compiler complains).
As for the other changes, ill fix the imports/newline issues and fix the
merge conflicts. I will also close #8248 #8247 #8243 #8241 and #8249 and merge
all those into a single PR. However, since I am new to Spark, can you tell me
what Jira I should open that PR against? Perhaps the umbrella SPARK-10014?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
