Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-134868225 `Lists.newArrayList` -> `Arrays.asList` look good to me. But I don't see why we need to replace `Strings` by `StringUtils` from commons-lang. Are we going to remove Guava from test scope? I think Guava is more careful about binary compatibility than Apache Commons. + @srowen
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org