Github user sabhyankar commented on the pull request:

    https://github.com/apache/spark/pull/8241#issuecomment-135121895
  
    @feynmanliang - That sounds good - I can document the intent of the 
Broadcastable trait in the scaladoc. The reason I made this trait 
private[spark] is because we want to use it in both mllib and ml models (e.g 
#8243). If I make this private[mllib], we wont be able to reuse it in the ml 
models unless we duplicate it... Any suggestions on how to work around this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to