Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8399#discussion_r38047496
  
    --- Diff: python/pyspark/ml/evaluation.py ---
    @@ -85,6 +88,9 @@ def _evaluate(self, dataset):
             self._transfer_params_to_java()
             return self._java_obj.evaluate(dataset._jdf)
     
    +    def isLargerBetter(self):
    +        return self._java_obj.isLargerBetter()
    --- End diff --
    
    This works for current use since it's called after evaluate has been 
called, but it could fail if a user calls it since the params may not have been 
transferred to java yet.  Call ```self._transfer_params_to_java()``` first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to