Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/7520#issuecomment-135285964
* This patch doesn't claim performance improvement. I know that
`OrcStructInspector` actually do very similar thing as `StructObjectInspector`.
This patch is proposed to only deal with the lowercase problem.
* Although Hive is a case-insensitive system and we just use lowercases in
the querying, I just wonder if we need to normalise the column names to
lowercases in persistence (such as ORC). Because according to
`OrcStructInspector`, I don't see it automatically perform the normalisation.
And you can find that we still keep the case-insensitive behavior when doing
query (I will add it in the unit test). In other words, this patch only
prevents automatically modifying the schema when serialising to ORC files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
