Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8477#discussion_r38140651
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala ---
    @@ -49,6 +49,8 @@ class Checkpoint(@transient ssc: StreamingContext, val 
checkpointTime: Time)
         // Reload properties for the checkpoint application since user wants 
to set a reload property
         // or spark had changed its value and user wants to set it back.
         val propertiesToReload = List(
    +      "spark.yarn.app.id",
    +      "spark.yarn.app.attemptId",
    --- End diff --
    
    This doesn't look right. If the AM restarted, the attempt ID will be 
different.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to