Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/7878#issuecomment-135911743
I think this is a good initial step; like Reynold, I'd prefer if this was
read from the PR's description. Perhaps the code can be amended later to get
the description using the github API and parsing it (and then you can get fancy
with how to declare test parameters too).
Also, it seems like the script to merge prs won't clean up these test
directives, right? That's more stuff to remember when merging PRs...
On the nits side:
- your description says "maven-test" while the directive is "test-maven"
- the actual code seems to match "test-maven", not "[test-maven]" as the PR
title suggests.
But overall I'm fine with it, we can keep on improving this in later PRs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
