Github user jeanlyn commented on a diff in the pull request: https://github.com/apache/spark/pull/7535#discussion_r38289221 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -129,6 +128,14 @@ trait CheckAnalysis { failAnalysis( s"unresolved operator ${operator.simpleString}") + case o if o.expressions.exists(!_.deterministic) && + !o.isInstanceOf[Project] && !o.isInstanceOf[Filter] => + failAnalysis( --- End diff -- Hi, @cloud-fan .Can it support for join operation? Sometimes we can use some `non deterministic ` expression to eval some pointless join keys(with respect to business logic) avoiding data skew. For example ```sql SELECT src.key, src.value, src1.value FROM src JOIN src1 ON UPPER((CASE WHEN (src.key IS NULL OR src.key = '' ) THEN CAST( (-RAND() * 10000000 ) AS string ) ELSE src.key END )) = UPPER(src1.key) ``` What do you think?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org