Github user rotationsymmetry commented on a diff in the pull request:
https://github.com/apache/spark/pull/8552#discussion_r38443083
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala ---
@@ -337,7 +337,7 @@ private[ml] trait HasStepSize extends Params {
* Param for Step size to be used for each iteration of optimization..
* @group param
*/
- final val stepSize: DoubleParam = new DoubleParam(this, "stepSize",
"Step size to be used for each iteration of optimization.")
+ final val stepSize: DoubleParam = new DoubleParam(this, "stepSize",
"Step size to be used for each iteration of optimization.",
ParamValidators.inRange(0, 1, lowerInclusive = false, upperInclusive = true))
--- End diff --
Do we want to enforce the stepsize <= 1?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
