Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-136974419
I have little knowledge of the metrics system. I can appreciate the
overhead of yet another config flag, and can also see how you might want to
monitor apps by instance (ID) or class (name) so to speak.
The change here seems like a fairly uninvasive version, as you can only
name an existing property to draw the value from, and it defaults to current
behavior. I can see the argument for limiting it further to "id" or "name" only.
I expect the downside are new bugs: my metrics failed because my app name
is "<WOOT>". Is there an extra issue of escaping anywhere here? IDs may not
have had such a problem.
It seems plausible to me, even if I feel like I don't know enough to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
