Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/4887#issuecomment-137240977
  
    > In the previous situation, it is aim to resolve memory_and_disk level 
block, first unroll failed, but it will reserved unroll memory for this task, 
and that unroll memory part should release after that block already put into 
disk, because nobody will use value from that unroll arrays. So it no necessary 
to reserved that unroll memory part.
    
    Oh I see, the idea is that once it's on disk we no longer need the `Array`, 
so we can just release the unroll memory since the `Array` will be garbage 
collected. This makes sense. Would you mind updating the title and description 
to be something more succinct?
    
    ```
    [SPARK-6157] [CORE] Unrolling with MEMORY_AND_DISK should always release 
memory
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to