Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8458#discussion_r38601927
--- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala
---
@@ -171,35 +183,53 @@ private[r] class RBackendHandler(server: RBackend)
}.toArray
}
- // Checks if the arguments passed in args matches the parameter types.
- // NOTE: Currently we do exact match. We may add type conversions later.
+ // Find a matching method in all methods of the same name of a class
+ // according to the passed arguments.
def matchMethod(
--- End diff --
sure. will add.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
