Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8599#discussion_r38806853
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -1519,6 +1519,19 @@ class SQLQuerySuite extends QueryTest with
SharedSQLContext {
|ORDER BY sum(b) + 1
""".stripMargin),
Row("4", 3) :: Row("1", 7) :: Row("3", 11) :: Row("2", 15) :: Nil)
+
+ Seq("1" -> 3, "2" -> 7, "2" -> 8, "3" -> 5, "3" -> 6, "3" -> 2, "4" ->
1, "4" -> 2,
+ "4" -> 3, "4" -> 4).toDF("a", "b").registerTempTable("orderByData2")
--- End diff --
How about `SELECT count(*) FROM orderByData GROUP BY a ORDER BY count(*)`?
The result would be `(2), (2), (2), (2)`.
Actually we don't need to test the correctness here, only need to make sure
`count(*)` works in ORDER BY.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
