Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8597#discussion_r38934989
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/JsonHadoopFsRelationSuite.scala
---
@@ -28,6 +28,14 @@ import org.apache.spark.sql.types._
class JsonHadoopFsRelationSuite extends HadoopFsRelationTest {
override val dataSourceName: String = "json"
+ // JSON does not write data of NullType and does not play well with
BinaryType.
+ override protected def supportsDataType(dataType: DataType): Boolean =
dataType match {
+ case a: NullType => false
+ case b: BinaryType => false
--- End diff --
But we do handle `BinaryType` [in `JacksonGenerator`] [1]. Does this mean
we can save a DataFrame containing `BinaryType` field(s) to JSON files via
`df.toJSON.saveAsTextFile(...)`, but can't read it back with `JSONRelation`?
[1]:
https://github.com/apache/spark/pull/8597/files#diff-0f04c36e499d4dcf6931fbd62b3aa012R101
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
