Github user avulanov commented on the pull request:
https://github.com/apache/spark/pull/8648#issuecomment-138679510
@feynmanliang Thank you for reviewing the code! I made one pass. It seems
that UFunc simplifies it a lot. However I am not sure about `.flatten` and
`.flatMap` on array of large arrays. We need to perform performance comparison.
Could you run the benchmark from https://github.com/avulanov/ann-benchmark
before and after refactoring to see the difference?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
