Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8610#discussion_r38983563
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/SparkDeploySchedulerBackend.scala
---
@@ -83,8 +83,16 @@ private[spark] class SparkDeploySchedulerBackend(
args, sc.executorEnvs, classPathEntries ++ testingClassPath,
libraryPathEntries, javaOpts)
val appUIAddress = sc.ui.map(_.appUIAddress).getOrElse("")
val coresPerExecutor =
conf.getOption("spark.executor.cores").map(_.toInt)
+ if (coresPerExecutor.isDefined && (coresPerExecutor.get <
scheduler.CPUS_PER_TASK ||
+ (coresPerExecutor.get % scheduler.CPUS_PER_TASK) != 0)) {
+ throw new SparkException(s"invalid configuration of " +
+ s"spark.executor.cores(${coresPerExecutor.get}) and " +
+ s"spark.task.cpus(${scheduler.CPUS_PER_TASK}}),
spark.executor.cores has to be no less " +
+ "than and folds of spark.task.cpus")
--- End diff --
I don't think this error message is super clear, what is meant by "no less
than and folds of spark.task.cups"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
