Github user noel-smith commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8657#discussion_r38990876
  
    --- Diff: python/pyspark/__init__.py ---
    @@ -48,6 +48,22 @@
     from pyspark.status import *
     from pyspark.profiler import Profiler, BasicProfiler
     
    +
    +def since(version):
    +    """
    +    A decorator that annotates a function to append the version of Spark 
the function was added.
    +    """
    +    import re
    +    indent_p = re.compile(r'\n( +)')
    +
    +    def deco(f):
    --- End diff --
    
    Would it be OK to add a clause to handle situations where f.__doc__ is 
None? There are a handful of methods without docstrings. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to