Github user jameszhouyi commented on the pull request:
https://github.com/apache/spark/pull/8652#issuecomment-138741073
After optimized patch , we can see "CartesianProduct" optimized to
"BroadcastNestedLoopJoin" from physical plan for cross join. The benchmark
result showed ~42% performance gain(15m1s vs. 26m37s).
== Physical Plan ==
TungstenProject [concat(cast(s_store_sk#454L as string),_,s_store_name#455)
AS store_ID#444,pr_review_date#447,pr_review_content#453]
BroadcastNestedLoopJoin BuildRight, Inner,
Some((locate(lower(s_store_name#455),lower(pr_review_content#453),1) >= 1))
HiveTableScan [pr_review_date#447,pr_review_content#453],
(MetastoreRelation bigbench, product_reviews, Some(pr))
HiveTableScan [s_store_sk#454L,s_store_name#455], (MetastoreRelation
bigbench, temp_stores_with_regression, Some(stores_with_regression))
Code Generation: true
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
