GitHub user cloud-fan opened a pull request:

    https://github.com/apache/spark/pull/8687

    [SPARK-9899][SQL][WIP] Disables customized output committer when 
speculation is enabled

    This is a follow-up of https://github.com/apache/spark/pull/8317.
    
    When speculation is enabled, there may be multiply tasks writing to the 
same path. Generally it's OK as we will write to a temporary directory first 
and only one task can commit the temporary directory to target path.
    
    However, when we use direct output committer, tasks will write data to 
target path directly without temporary directory. This causes problems like 
corrupted data. Please see [PR 
comment](https://github.com/apache/spark/pull/8191#issuecomment-131598385) for 
more details.
    
    Unfortunately, we don't have a simple flag to tell if a output committer 
will write to temporary directory or not, so for safety, we have to disable all 
customized output committer when `speculation` is true.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloud-fan/spark direct-committer

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/8687.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8687
    
----
commit 9987c869be3ec5994355d831a1031211b069b9ce
Author: Wenchen Fan <cloud0...@outlook.com>
Date:   2015-09-10T07:08:30Z

    deny customized output committer when speculation is enabled

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to