Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7403#issuecomment-139322895
@massie This looks OK to me. The only thing is that I find the name
`combineByKeyWithClassTag` awkward, and because it's a public API we won't be
able to remove it in the future. I understand that it won't compile if you just
call it `combineByKey`, but I wonder if we should at least mark these
`@DeveloperApi` or something so we're not fully committed to keeping the
signatures exactly as they currently are in the future.
I'll defer the judgment to @rxin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
