Github user zjffdu commented on the pull request:
https://github.com/apache/spark/pull/8688#issuecomment-139463912
Thanks for the review @vanzin
For SparkUI, yes it is not necessary to put appId in constructor. But for
history server, the appId is known when creating SparkUI. Although in history
server the appId of SparkUI is never used for now. But for safety, I put appId
in constructor in case appId will be used in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
