Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/5700#discussion_r39257887
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -413,6 +418,10 @@ object BooleanSimplification extends Rule[LogicalPlan]
with PredicateHelper {
case LessThan(l, r) => GreaterThanOrEqual(l, r)
// not(l <= r) => l > r
case LessThanOrEqual(l, r) => GreaterThan(l, r)
+ // not(l || r) => not(l) && not(r)
+ case Or(l, r) => And(Not(l), Not(r))
+ // not(l && r) => not(l) or not(r)
+ case And(l, r) => Or(Not(l), Not(r))
--- End diff --
At first I thought this optimization should be only used in datasource as
it may cause performance regression for normal cases(see these
[comments](https://github.com/apache/spark/pull/8200#discussion-diff-37154582)).
However after an offline discussion with @marmbrus , this optimization is
pretty standard and generally good, so let's keep it in `Optimizer` :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
