Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8707#issuecomment-139618711 Actually, one point of confusion: it looks like `python/pyspark/serializers.py` had some methods for serializing namedtuple classes with its `_restore` and `_hack_namedtuple(cls)` methods, but this patch also adds logic to `cloudpickle.py` to handle pickling of these instances. Do we need both of these methods? Are some only needed by certain versions of Python? It would be good to add some comments to explain some of this stuff, since it's not obvious from reading the code.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org