Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8766#discussion_r39536841
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -65,3 +75,18 @@ private[spark] class SystemClock extends Clock {
-1
--- End diff --
nit: not your fault, but generally when code is not reachable I like to
throw an exception instead of returning a dummy value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
