Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8771#discussion_r39583517
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackendSuite.scala
---
@@ -184,4 +184,52 @@ class CoarseMesosSchedulerBackendSuite extends
SparkFunSuite
verify(driver, times(1)).reviveOffers()
}
+
+ test("testing various isOfferValidForScheduling cases") {
--- End diff --
Ideally I would like to see each test case tests one condition as it's hard
to know what's going on here.
Can you at least organized them to related ones (constraints, required
mem/cpu, etc).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
