Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8791#discussion_r39726654
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
    @@ -198,7 +198,7 @@ class StreamingContext private[streaming] (
     
       private var state: StreamingContextState = INITIALIZED
     
    -  private val startSite = new AtomicReference[CallSite](null)
    +  private[streaming] val startSite = new AtomicReference[CallSite](null)
    --- End diff --
    
    Looks it's better to add a new method like
    ```
    private[streaming] def getStartSite: String = startSite.get()
    ``` 
    rather than exposing `AtomicReference`. In addition, this one won't break 
MiMa tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to