Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/1143#issuecomment-46646277 LGTM. Making everything other than `eval` to be `private[this]` makes sense, so that `eval` is guaranteed to be the only entrance of type casting and the null check won't be skipped.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---