Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8799#discussion_r39908195
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcQuerySuite.scala ---
@@ -344,4 +344,34 @@ class OrcQuerySuite extends QueryTest with
BeforeAndAfterAll with OrcTest {
}
}
}
+
+ test("SPARK-10623 Enable ORC PPD") {
+ withTempPath { dir =>
+ withSQLConf(SQLConf.ORC_FILTER_PUSHDOWN_ENABLED.key -> "true") {
+ import testImplicits._
+
+ val path = dir.getCanonicalPath
+ sqlContext.range(10).coalesce(1).write.orc(path)
+ val df = sqlContext.read.orc(path)
+
+ def checkPredicate(pred: Column, answer: Seq[Long]): Unit = {
+ checkAnswer(df.where(pred), answer.map(Row(_)))
--- End diff --
Does this test check if the predicate is really pushded down? Or it just
check answers?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
