Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8831#discussion_r39917683
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleManager.scala ---
@@ -24,7 +24,13 @@ import org.apache.spark.shuffle._
* A ShuffleManager using hashing, that creates one output file per reduce
partition on each
* mapper (possibly reusing these across waves of tasks).
*/
-private[spark] class HashShuffleManager(conf: SparkConf) extends
ShuffleManager {
+private[spark] class HashShuffleManager(conf: SparkConf) extends
ShuffleManager with Logging {
+
+ if (!conf.getBoolean("spark.shuffle.spill", true)) {
--- End diff --
how about adding this to sparkconf itself, and don't have these here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
