Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/8357#discussion_r39919354
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -37,7 +37,7 @@ import org.apache.spark.unsafe.types.CalendarInterval
* This is currently included mostly for illustrative purposes. Users
wanting more complete support
* for a SQL like language should checkout the HiveQL support in the
sql/hive sub-project.
*/
-class SqlParser extends AbstractSparkSQLParser with DataTypeParser {
+object SqlParser extends AbstractSparkSQLParser with DataTypeParser {
def parseExpression(input: String): Expression = {
--- End diff --
> Can we just lock it instead of assuming our sql parser is thread safe?
Added
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
