Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6457#discussion_r39925480
--- Diff: core/src/test/scala/org/apache/spark/rpc/RpcEnvSuite.scala ---
@@ -535,15 +538,82 @@ abstract class RpcEnvSuite extends SparkFunSuite with
BeforeAndAfterAll {
"local", env.address, "sendWithReply-unserializable-error")
try {
val f = rpcEndpointRef.ask[String]("hello")
- intercept[TimeoutException] {
+ val e = intercept[Exception] {
Await.result(f, 1 seconds)
}
+ assert(e.isInstanceOf[TimeoutException] || // For Akka
+ e.isInstanceOf[NotSerializableException] // For Netty
+ )
} finally {
anotherEnv.shutdown()
anotherEnv.awaitTermination()
}
}
+ test("port conflict") {
+ val anotherEnv = createRpcEnv(new SparkConf(), "remote",
env.address.port)
+ assert(anotherEnv.address.port != env.address.port)
+ }
+
+ test("send with ssl") {
+ val conf = new SparkConf
+ conf.set("spark.authenticate", "true")
+ conf.set("spark.authenticate.secret", "good")
+
+ val localEnv = createRpcEnv(conf, "ssl-local", 13345)
+ val remoteEnv = createRpcEnv(conf, "ssl-remote", 14345)
+
+ try {
+ @volatile var message: String = null
+ localEnv.setupEndpoint("send-ssl", new RpcEndpoint {
+ override val rpcEnv = localEnv
+
+ override def receive: PartialFunction[Any, Unit] = {
+ case msg: String => message = msg
+ }
+ })
+ val rpcEndpointRef = remoteEnv.setupEndpointRef("ssl-local",
localEnv.address, "send-ssl")
+ rpcEndpointRef.send("hello")
+ eventually(timeout(5 seconds), interval(10 millis)) {
+ assert("hello" === message)
+ }
+ } finally {
+ localEnv.shutdown()
+ localEnv.awaitTermination()
+ remoteEnv.shutdown()
+ remoteEnv.awaitTermination()
+ }
+ }
+
+ test("ask with ssl") {
--- End diff --
same, I think you really mean `authentication` instead of `ssl`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
