Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/8843#discussion_r39932951
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java
---
@@ -73,7 +76,9 @@ public void loadNext() throws IOException {
numRecordsRemaining--;
if (numRecordsRemaining == 0) {
in.close();
- file.delete();
+ if (!file.delete()) {
+ logger.error("Unable to delete spill file {}", file.getPath());
--- End diff --
Is the file going to be cleaned later ?
Do you have any suggestion w.r.t. what log level should be used ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
