Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141832701
Yeah I'm mixing up a few things here. You're right none of them do have
header files. I think the template files should have the same header IMHO
unless there's some reason they can't contain one, or maybe someone had a good
reason that they don't need it. Maybe that's a separate point.
Skipping `spark-defaults.conf` isn't a problem I think, since it would not
be from the project anyway. If it's a developer convenience, OK, even if you
probably wouldn't normally have this in your distro directory if you're
packaging Spark.
But yeah only that file should be skipped too, to keep it conservative.
`spark-defaults.conf.*` didn't look loike it matched `spark-defaults.conf`,
but, aha, this file is actually intended to contain regexes? then it does yes.
Then, lots of entries in this file aren't quite expressing what they mean to,
like "service.properties" or "test_support/*" or arguably ".*iws". Then I see a
bunch of entries that probably shouldn't be there like "local-1422981759269/*"
So, I propose that this change at least only affect `spark-defaults.conf`
but if you're up for it, I think there is significant additional cleanup that
could be done here!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
