Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8631#discussion_r39937140
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -520,28 +544,28 @@ private class LeastSquaresAggregator(
* Add a new training data to this LeastSquaresAggregator, and update
the loss and gradient
* of the objective function.
*
- * @param label The label for this data point.
- * @param data The features for one data point in dense/sparse vector
format to be added
- * into this aggregator.
+ * @param data The data point to be added.
* @return This LeastSquaresAggregator object.
*/
- def add(label: Double, data: Vector): this.type = {
- require(dim == data.size, s"Dimensions mismatch when adding new
sample." +
- s" Expecting $dim but got ${data.size}.")
+ def add(data: Instance): this.type = data match { case Instance(label,
weight, features) =>
+ require(dim == features.size, s"Dimensions mismatch when adding new
sample." +
+ s" Expecting $dim but got ${features.size}.")
+ require(weight >= 0.0, s"instance weight, ${weight} has to be >= 0.0")
--- End diff --
Please add `if (weight == 0) return this`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
