Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8214#discussion_r39956478
  
    --- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
    @@ -133,7 +133,10 @@ def get$Name(self):
             ("thresholds", "Thresholds in multi-class classification to adjust 
the probability of " +
              "predicting each class. Array must have length equal to the 
number of classes, with " +
              "values >= 0. The class with largest value p/t is predicted, 
where p is the original " +
    -         "probability of that class and t is the class' threshold.", None)]
    +         "probability of that class and t is the class' threshold.", None),
    +        ("weightCol", "weight column name. If this is not set or empty, we 
treat " +
    +         "all instance weights as 1.0.", None)]
    --- End diff --
    
    nit: Should remove dot after 1.0, otherwise it will produce two dots at 
L575.
    Maybe other lines in the ```shard``` array have the same issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to