Github user travishegner commented on the pull request:
https://github.com/apache/spark/pull/8780#issuecomment-142100699
OK, after looking at this a little further, it seems that
DecimalType.bounded() should be called regardless of precision and scale values
in JDBCRDD.scala, and then let the .bounded() method validate the precision and
scale values. If it finds invalid values, it can return defaults, or throw an
exception, depending on which condition is met. I'm going to move in that
direction for this.
I'm still a little confused by the precision and scale rules that you
defined. Wouldn't it be invalid to have a precision = 10, but a scale = -20?
Wouldn't that always result in a null value, or am I still completely
interpreting precision and scale incorrectly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
