Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/8820#discussion_r40118057 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/impl/NodeIdCache.scala --- @@ -131,7 +131,7 @@ private[spark] class NodeIdCache( rddUpdateCount += 1 // Handle checkpointing if the directory is not None. - if (nodeIdsForInstances.sparkContext.getCheckpointDir.nonEmpty && + if (nodeIdsForInstances.sparkContext.getCheckpointDir.nonEmpty && checkpointInterval != -1 && --- End diff -- This should be changed in the spark.ml version of NodeIdCache. (I know this is confusing having two copies of it. I'm planning on removing the old one during this release.)
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org