Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/686#discussion_r14032954
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -313,6 +314,47 @@ class DAGSchedulerSuite extends
TestKit(ActorSystem("DAGSchedulerSuite")) with F
assertDataStructuresEmpty
}
+ test("job cancellation no-kill backend") {
+ // make sure that the DAGScheduler doesn't crash when the TaskScheduler
+ // doesn't implement killTask()
+ val noKillTaskScheduler = new TaskScheduler() {
+ override def rootPool: Pool = null
+ override def schedulingMode: SchedulingMode = SchedulingMode.NONE
+ override def start() = {}
+ override def stop() = {}
+ override def submitTasks(taskSet: TaskSet) = {
+ // normally done by TaskSetManager
+ taskSet.tasks.foreach(_.epoch = mapOutputTracker.getEpoch)
--- End diff --
Sure, doing nothing is easy.
On Fri, Jun 20, 2014 at 10:47 AM, Kay Ousterhout <notificati...@github.com>
wrote:
> In core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala:
>
> > @@ -313,6 +314,47 @@ class DAGSchedulerSuite extends
TestKit(ActorSystem("DAGSchedulerSuite")) with F
> > assertDataStructuresEmpty
> > }
> >
> > + test("job cancellation no-kill backend") {
> > + // make sure that the DAGScheduler doesn't crash when the
TaskScheduler
> > + // doesn't implement killTask()
> > + val noKillTaskScheduler = new TaskScheduler() {
> > + override def rootPool: Pool = null
> > + override def schedulingMode: SchedulingMode = SchedulingMode.NONE
> > + override def start() = {}
> > + override def stop() = {}
> > + override def submitTasks(taskSet: TaskSet) = {
> > + // normally done by TaskSetManager
> > + taskSet.tasks.foreach(_.epoch = mapOutputTracker.getEpoch)
>
> are these lines necessary (can you just do nothing here?)
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/686/files#r14031997>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
