Github user dusenberrymw commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8112#discussion_r40274444
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
    @@ -80,7 +96,18 @@ class CrossValidator(override val uid: String) extends 
Estimator[CrossValidatorM
         val epm = $(estimatorParamMaps)
         val numModels = epm.length
         val metrics = new Array[Double](epm.length)
    -    val splits = MLUtils.kFold(dataset.rdd, $(numFolds), 0)
    +    val splits = if (schema.fieldNames.contains($(stratifiedCol))) {
    --- End diff --
    
    I would check `isSet(stratifiedCol)` here to make sure the user set the 
stratified column, just in case a column in the dataset was actually named 
"None".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to