Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8911#discussion_r40404934
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala
---
@@ -385,20 +385,13 @@ class SparkHadoopUtil extends Logging {
object SparkHadoopUtil {
- private val hadoop = {
- val yarnMode = java.lang.Boolean.valueOf(
- System.getProperty("SPARK_YARN_MODE",
System.getenv("SPARK_YARN_MODE")))
- if (yarnMode) {
- try {
-
Utils.classForName("org.apache.spark.deploy.yarn.YarnSparkHadoopUtil")
- .newInstance()
- .asInstanceOf[SparkHadoopUtil]
- } catch {
- case e: Exception => throw new SparkException("Unable to load YARN
support", e)
- }
- } else {
- new SparkHadoopUtil
- }
+ private lazy val hadoop = new SparkHadoopUtil
+ private lazy val yarn = try{
--- End diff --
LGTM. Only trivial things to suggest like a space after 'try'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
