Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/8908#issuecomment-143306461 Thanks @olarayej -- I just had a couple of minor style comments One more thing is that it will be good to add a unit test for this. You could just add a test case to some of the existing tests at https://github.com/apache/spark/blob/922338812c03eba43f2f1a6c414d1b6b049811cf/R/pkg/inst/tests/test_sparkSQL.R#L215
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org